linux-kernel - Re: [PATCH] x86: ioapic: Fix irq_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.03.1406301613100.4699@AMR>
Date:	Mon, 30 Jun 2014 16:15:01 -0600 (MDT)
From:	Keith Busch <keith.busch@...el.com>
To:	David Rientjes <rientjes@...gle.com>
cc:	Keith Busch <keith.busch@...el.com>, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org
Subject: Re: [PATCH] x86: ioapic: Fix irq_free_descs count

On Mon, 30 Jun 2014, David Rientjes wrote:
> On Mon, 30 Jun 2014, Keith Busch wrote:
>
>> Signed-off-by: Keith Busch <keith.busch@...el.com>
>> Cc: Thomas Gleixner <tglx@...utronix.de>
>> Cc: x86@...nel.org
>
> Acked-by: David Rientjes <rientjes@...gle.com>
>
> This is definitely a fix for "genirq: Provide generic hwirq allocation
> facility", but the changelog doesn't describe what the problem is and the
> title that this somehow fixes irq_free_descs() doesn't make any sense.

My mistake, I used the component from the commit I bisected the bug
down to.

> It's the equivalent of just doing
>
> -	irq_free_descs(from, cnt);
> +	irq_free_descs(from, i - from);
>
> I'd suggest the patch title be changed to
>
> 	genirq: Fix memory leak when calling irq_free_hwirqs()
>
> and the changelog state
>
> irq_free_hwirqs() always calls irq_free_descs() with a cnt == 0 which
> makes it a no-op since the interrupt count to free is decremented in
> itself.

Yes, I like your suggestion. Should I submit a v2, or will maintainer
replace the changelog?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/