linux-kernel - Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53B2CE15.7010403@wwwdotorg.org>
Date:	Tue, 01 Jul 2014 09:04:53 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Vidya Sagar <vidyas@...dia.com>, bhelgaas@...gle.com, rjw@...k.pl,
	nagananda.chumbalkar@...com, thierry.reding@...il.com,
	swarren@...dia.com, kthota@...dia.com, linux-pci@...r.kernel.org
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode

On 07/01/2014 01:16 AM, Vidya Sagar wrote:
> commit 1a680b7c moved pcie_aspm_powersave_config_link() out of
> pci_raw_set_power_state() to pci_set_power_state() which would enable
> ASPM. But, with commit db288c9c, which re-introduced the following check
> ./drivers/pci/pci.c: pci_set_power_state()
> +   /* Check if we're already there */
> +   if (dev->current_state == state)
> +       return 0;
> in pci_set_power_state(), call to pcie_aspm_powersave_config_link() is never
> made leaving ASPM broken.
> Fix it by not returning from when the above condition is true, rather, jump to
> ASPM configuration code and exit from there eventually.

Out of curiosity, was this patch tested by running an umodified mainline
kernel on a Tegra device, or is this simply a port from our downstream
kernel, without any additional upstream testing?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/