linux-kernel - Re: [PATCH 03/33] clk: at91: main: warn when the main crystal frequency is not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140702102315.1a508747@bbrezillon>
Date:	Wed, 2 Jul 2014 10:23:15 +0200
From:	Boris BREZILLON <boris.brezillon@...e-electrons.com>
To:	Boris BREZILLON <boris.brezillon@...e-electrons.com>
Cc:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Mike Turquette <mturquette@...aro.org>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/33] clk: at91: main: warn when the main crystal
 frequency is not set

On Wed, 2 Jul 2014 10:18:11 +0200
Boris BREZILLON <boris.brezillon@...e-electrons.com> wrote:

> On Tue,  1 Jul 2014 16:12:12 +0200
> Alexandre Belloni <alexandre.belloni@...e-electrons.com> wrote:
> 
> > When the main crystal frequency is not set, the main clock is
> > approximated using the MAINF value in the CKGR_MCFR register. Warn
> > the user in that case.
> > 
> > Signed-off-by: Alexandre Belloni
> > <alexandre.belloni@...e-electrons.com> ---
> 
> Acked-by: Boris BREZILLON <boris.brezillon@...rkiz.com>

Sorry, it seems I kinda regret my former employer :-).

This is of course:

Acked-by: Boris BREZILLON <boris.brezillon@...e-electrons.com>

> 
> Mike, do you want me to take this patch and send you a pull request,
> or should I let you take this one directly ?
> 
> Best Regards,
> 
> Boris
> 
> >  drivers/clk/at91/clk-main.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/clk/at91/clk-main.c
> > b/drivers/clk/at91/clk-main.c index 733306131b99..59fa3cc96c9e
> > 100644 --- a/drivers/clk/at91/clk-main.c
> > +++ b/drivers/clk/at91/clk-main.c
> > @@ -388,6 +388,7 @@ static unsigned long clk_main_recalc_rate(struct
> > at91_pmc *pmc, if (parent_rate)
> >  		return parent_rate;
> >  
> > +	pr_warn("Main crystal frequency not set, using approximate
> > value\n"); tmp = pmc_read(pmc, AT91_CKGR_MCFR);
> >  	if (!(tmp & AT91_PMC_MAINRDY))
> >  		return 0;
> 
> 
> 



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/