linux-kernel - Re: [V2 PATCH] ALSA: hda - Enable mute/mic-mute LEDs for more Thinkpads with Conexant codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 03 Jul 2014 09:04:02 +0200
From:	Jan Kiszka <jan.kiszka@....de>
To:	Hui Wang <hui.wang@...onical.com>
CC:	Hui Wang <jason77.wang@...il.com>, tiwai@...e.de,
	alsa-devel@...a-project.org, alex.hung@...onical.com,
	yk@...onical.com, david.henningsson@...onical.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [V2 PATCH] ALSA: hda - Enable mute/mic-mute LEDs for more Thinkpads
 with Conexant codec

On 2014-07-01 11:26, Hui Wang wrote:
> On 07/01/2014 03:38 PM, Jan Kiszka wrote:
>> On 2014-07-01 04:15, Hui Wang wrote:
>>> On 06/30/2014 02:45 PM, Jan Kiszka wrote:
>>>> On 2014-06-30 04:04, Hui Wang wrote:
>>>>> On 06/29/2014 07:33 PM, Jan Kiszka wrote:
>>>>>> On 2013-11-27 07:47, Hui Wang wrote:
>>>>>>> Most Thinkpad Edge series laptops use conexant codec, so far
>>>>>>> although
> <snip>
>>>>>>>
>>>> Is there anything I can debug or any information I can collect from my
>>>> box to examine this?
>>> What is the linux distribution on your machine? And use showkey to catch
>>> the keycode of that button.
>> I'm running OpenSUSE 13.1. The reported keycode of the power button is
>> 116.
> It seems the keycode is correct, it is power keycode rather the mute
> keycode.
> 
> Could you please do some debug, let us find which line of code is the
> root cause for this problem. for example:
> 
> after running the line, the problem shows up:
> 
> 1.     if (ACPI_SUCCESS(acpi_get_devices("LEN0068", acpi_check_cb,
> &found, NULL)) && found) // in the sound/pci/hda/thinkpad_helper.c,
> is_thinkpad()

This evaluates to true

> 
> 2.     return ACPI_SUCCESS(acpi_get_devices("IBM0068", acpi_check_cb,
> &found, NULL)) && found; // same as above
> 
> 3.         if (led_set_func(TPACPI_LED_MUTE, false) >= 0) { //in the
> sound/pci/hda/thinkpad_helper.c, hda_fixup_thinkpad_acpi()

...and this

> 
> 4. if (led_set_func(TPACPI_LED_MICMUTE, false) >= 0) { // same as above
> 

...and this as well. spec->num_adc_nids is 1.

Jan



Download attachment "signature.asc" of type "application/pgp-signature" (264 bytes)