lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <53B50105.1060005@baslerweb.com>
Date:	Thu, 3 Jul 2014 09:06:45 +0200
From:	Stefan Klug <stefan.klug@...lerweb.com>
To:	Greg KH <greg@...ah.com>
CC:	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<stern@...land.harvard.edu>
Subject: Re: [PATCH][RFC] USB: zerocopy support for usbfs


On 02.07.2014 19:55, Greg KH wrote:
> Very nice. 
Thanks.
> Minor non-technical issues here, your patch is corrupted (linewrapped 
> and tabs converted to spaces) and can't be applied at all. Can you fix 
> your email client and try again? Look at 
> Documentation/email_clients.txt for hints on how to do this.
Hm, I thought I checked that one. Sorry. I'll test and resend correctly.
>> --- a/drivers/usb/core/devio.c
>> +++ b/drivers/usb/core/devio.c
>> @@ -4,6 +4,7 @@
>>    *      devio.c  --  User space communication with USB devices.
>>    *
>>    *      Copyright (C) 1999-2000  Thomas Sailer (sailer@....ee.ethz.ch)
>> + *      Copyright (C) 2014  Stefan Klug (stefan.klug@...lerweb.com)
> According to legal advice given to me, this isn't needed / true, so can
> you drop it?  Or, if you have different legal advice, might I ask for
> what the legal justification is that this needs to be added?
No problem. I'll remove them.
>
>>    *      This program is free software; you can redistribute it and/or
>> modify
>>    *      it under the terms of the GNU General Public License as published
>> by
>> @@ -30,6 +31,7 @@
>>    *    04.01.2000   0.2   Turned into its own filesystem
>>    *    30.09.2005   0.3   Fix user-triggerable oops in async URB delivery
>>    *                 (CAN-2005-3055)
>> + *    07.05.2014   0.4   Added zerocopy support
> No need to do this, we use git now and that's where the changelog goes.
> We should just delete this "fake changelog" entirely from this file.
I'll remove the line and maybe prepare a cleanup patch later.


Stefan Klug
Software Developer

Basler AG
An der Strusbek 60-62
22926 Ahrensburg
Germany

Tel. +49 4102 463 582
Fax +49 4102 463 46 582
 
Stefan.Klug@...lerweb.com

www.baslerweb.com

Vorstand: Dr.-Ing. Dietmar Ley (Vorsitzender) · John P. Jennings · Arndt Bake · Hardy Mehl
Aufsichtsratsvorsitzender: Norbert Basler 
Basler AG · Amtsgericht Lübeck HRB 4090 · Ust-IdNr.: DE 135 098 121 · Steuer-Nr.: 30 292 04497 · WEEE-Reg.-Nr. DE 83888045
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ