linux-kernel - Re: [PATCH v3 4/5] ALSA: pcm_dmaengine: Correct support for 24bits physical sample widths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53B51462.1090805@metafoo.de>
Date:	Thu, 03 Jul 2014 10:29:22 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Peter Ujfalusi <peter.ujfalusi@...com>, vinod.koul@...el.com,
	dan.j.williams@...el.com, tiwai@...e.de,
	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>, joelf@...com,
	nsekhar@...com
CC:	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	dmaengine@...r.kernel.org
Subject: Re: [PATCH v3 4/5] ALSA: pcm_dmaengine: Correct support for 24bits
 physical sample widths

On 07/03/2014 06:51 AM, Peter Ujfalusi wrote:
> In case of _3LE/_3BE formats the samples are stored in 3 consecutive bytes
> without padding it to 4 bytes. This means that the DMA needs to be able to
> support 3 bytes word length in order to read/write the samples from memory
> correctly. Originally the code treated 24 bits physical length samples as
> they were 32 bits which leads to corruption when playing or recording audio.
>
> The hw.formats field has already been prepared to exclude formats not
> supported by the DMA engine in use, which means that only on platforms where
> 3 bytes is supported by the DMA will be able to use this format.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>

Acked-by: Lars-Peter Clausen <lars@...afoo.de>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/