[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <53B5155E.7050103@metafoo.de>
Date: Thu, 03 Jul 2014 10:33:34 +0200
From: Lars-Peter Clausen <lars@...afoo.de>
To: Peter Ujfalusi <peter.ujfalusi@...com>, vinod.koul@...el.com,
dan.j.williams@...el.com, tiwai@...e.de,
Mark Brown <broonie@...nel.org>,
Liam Girdwood <lgirdwood@...il.com>, joelf@...com,
nsekhar@...com
CC: linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
dmaengine@...r.kernel.org
Subject: Re: [PATCH v3 0/5] ALSA/ASoC/dmaengine: Fix 3 bytes physical sample
support
On 07/03/2014 06:51 AM, Peter Ujfalusi wrote:
[...]
>
> First step is to add DMA_SLAVE_BUSWIDTH_3_BYTES to dma_slave_buswidth for
> engines and users to select 3 bytes as bus width.
>
> Followed by:
> In dmaengine_pcm_set_runtime_hwparams() we should check the slave_caps of the
> dma if it supports the give sample physical width of the sample. Based on this
> information we initialize the hw.formats: masking out all non supported formats
> based on the physical width.
> In case the dma driver does not implement the slave_caps the default assumption
> is that it supports 1, 2 and 4 bytes widths.
The whole series looks good to me. Since both the DMA and ALSA bits changed
in this series are fairly trivial I think it is best to merge the whole
series through the ASoC tree.
- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists