linux-kernel - Re: [PATCH 2/2] mach-spear: fixed spear1340.c file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDOMVh0qyjq11kKaO2ndYhLW8j+dZyv3-c89BBcO1AxY+fiHQ@mail.gmail.com>
Date:	Thu, 3 Jul 2014 14:08:13 -0400
From:	Nick Krause <xerofoify@...il.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Viresh Kumar <viresh.linux@...il.com>,
	Shiraz Hashim <shiraz.linux.kernel@...il.com>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	spear-devel@...t.st.com, linux-arm-kernel@...ts.infradead.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] mach-spear: fixed spear1340.c file

Yes it is and I did it in two patches in order to be more readable.
Furthermore I don't known Kconfig well enough to do the Makefile
for the file I created.
Cheers Nick

On Thu, Jul 3, 2014 at 2:04 PM, Paul Bolle <pebolle@...cali.nl> wrote:
> On Wed, 2014-07-02 at 22:36 -0400, Nicholas Krause wrote:
>> This is the fixed file after moving sata support to new file in
>> spear1340_sata.c
>>
>> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
>> ---
>>  arch/arm/mach-spear/spear1340.c | 111 ----------------------------------------
>>  1 file changed, 111 deletions(-)
>
> This patch, together with patch 1/2, basically moves a chunk of code
> into a separate file, didn't it? If so, why did you split that move in
> two patches?
>
> And how does all this work without any changes to a Makefile?
>
>> diff --git a/arch/arm/mach-spear/spear1340.c b/arch/arm/mach-spear/spear1340.c
>> index 7b6bff7..f9d8ef3 100644
>> --- a/arch/arm/mach-spear/spear1340.c
>> +++ b/arch/arm/mach-spear/spear1340.c
>> @@ -21,117 +21,6 @@
>>  #include "generic.h"
>>  #include <mach/spear.h>
>>
>> -/* FIXME: Move SATA PHY code into a standalone driver */
>
> (I have no idea what this FIXME is about, but I do wonder whether that
> new file by itself is the standalone driver this FIXME is about. The
> spear developers will surely know.)
>
>
> Paul Bolle
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/