linux-kernel - Re: [PATCH 2/2] mach-spear: fixed spear1340.c file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1404412596.16291.30.camel@x220>
Date:	Thu, 03 Jul 2014 20:36:36 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Nick Krause <xerofoify@...il.com>
Cc:	Viresh Kumar <viresh.linux@...il.com>,
	Shiraz Hashim <shiraz.linux.kernel@...il.com>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	spear-devel@...t.st.com, linux-arm-kernel@...ts.infradead.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] mach-spear: fixed spear1340.c file

[I fixed the top posting.]

On Thu, 2014-07-03 at 14:08 -0400, Nick Krause wrote:
> On Thu, Jul 3, 2014 at 2:04 PM, Paul Bolle <pebolle@...cali.nl> wrote:
> > This patch, together with patch 1/2, basically moves a chunk of code
> > into a separate file, didn't it? If so, why did you split that move in
> > two patches?
>
> Yes it is and I did it in two patches in order to be more readable.

It makes it harder to understand the change (I had to _guess_ it was a
move). Moreover, depending on the order that these two patches would be
merged, we could end up with a chunk of code being either included twice
or not included at all, in some range of commits. Neither would be good.

> > And how does all this work without any changes to a Makefile?
>
> Furthermore I don't known Kconfig well enough to do the Makefile
> for the file I created.

Then I think you should, well, study the kernel build system before
submitting a change like this. And you can also ask a question or two to
get things going. (Not sure what the relevant list would be.)


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/