linux-kernel - Re: [PATCH 3.12 13/72] floppy: bail out in open() if drive is not responding to block0 read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 4 Jul 2014 23:22:29 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Olaf Hering <olaf@...fle.de>
cc:	Jiri Slaby <jslaby@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3.12 13/72] floppy: bail out in open() if drive is not
 responding to block0 read

On Thu, 3 Jul 2014, Olaf Hering wrote:

> > From: Jiri Kosina <jkosina@...e.cz>
> 
> > commit 7b7b68bba5ef23734c35ffb0d8d82079ed604d33 upstream.
> 
> > +static void floppy_rb0_cb(struct bio *bio, int err)
> >  {
> > -	complete((struct completion *)bio->bi_private);
> > +	struct rb0_cbdata *cbdata = (struct rb0_cbdata *)bio->bi_private;
> > +	int drive = cbdata->drive;
> > +
> > +	if (err) {
> > +		pr_info("floppy: error %d while reading block 0", err);
> 
> This change lacks a newline...

Fixed by 1c65df3d7 in Linus' tree.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/