lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Jul 2014 14:04:41 -0500 From: Rob Herring <robherring2@...il.com> To: Will Deacon <will.deacon@....com> Cc: Liviu Dudau <Liviu.Dudau@....com>, Sinan Kaya <okaya@...eaurora.org>, linaro-kernel <linaro-kernel@...ts.linaro.org>, Catalin Marinas <Catalin.Marinas@....com>, Device Tree ML <devicetree@...r.kernel.org>, linux-pci <linux-pci@...r.kernel.org>, Jingoo Han <jg1.han@...sung.com>, LKML <linux-kernel@...r.kernel.org>, Kukjin Kim <kgene.kim@...sung.com>, Tanmay Inamdar <tinamdar@....com>, Suravee Suthikulanit <suravee.suthikulpanit@....com>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Bjorn Helgaas <bhelgaas@...gle.com>, LAKML <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v8 7/9] pci: of: Parse and map the IRQ when adding the PCI device. On Wed, Jul 2, 2014 at 6:17 AM, Will Deacon <will.deacon@....com> wrote: > On Tue, Jul 01, 2014 at 07:43:32PM +0100, Liviu Dudau wrote: >> Enhance the default implementation of pcibios_add_device() to >> parse and map the IRQ of the device if a DT binding is available. >> >> Signed-off-by: Liviu Dudau <Liviu.Dudau@....com> >> --- >> drivers/pci/pci.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c >> index 63a54a3..8e65dc3 100644 >> --- a/drivers/pci/pci.c >> +++ b/drivers/pci/pci.c >> @@ -17,6 +17,7 @@ >> #include <linux/spinlock.h> >> #include <linux/string.h> >> #include <linux/log2.h> >> +#include <linux/of_pci.h> >> #include <linux/pci-aspm.h> >> #include <linux/pm_wakeup.h> >> #include <linux/interrupt.h> >> @@ -1453,6 +1454,9 @@ EXPORT_SYMBOL(pcim_pin_device); >> */ >> int __weak pcibios_add_device(struct pci_dev *dev) >> { >> +#ifdef CONFIG_OF >> + dev->irq = of_irq_parse_and_map_pci(dev, 0, 0); >> +#endif > > You could avoid the #ifdef by only assigning dev->irq if > of_irq_parse_and_map_pci returned something > 0. Perhaps it could just be unconditional always. Presumably, dev->irq is not already set to something valid and setting it to <= 0 should not have any consequences. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists