lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Jul 2014 22:23:18 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> Cc: Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>, Tomi Valkeinen <tomi.valkeinen@...com>, Rickard Strandqvist <rickard.strandqvist@...ymobile.com>, Jingoo Han <jg1.han@...sung.com>, Daniel Vetter <daniel.vetter@...ll.ch>, Mauro Carvalho Chehab <m.chehab@...sung.com>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, "Chen, Gong" <gong.chen@...ux.intel.com>, linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] video: fbdev: sis: init.c: Cleaning up variable that is never used On Sat, Jul 05, 2014 at 02:48:27PM +0200, Rickard Strandqvist wrote: > From: Rickard Strandqvist <rickard.strandqvist@...ymobile.com> These for lines are for when you are sending on someone else's behalf. > > Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > --- > drivers/video/fbdev/sis/init.c | 21 +++++---------------- > 1 file changed, 5 insertions(+), 16 deletions(-) > > diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c > index bd40f5e..3ba446c 100644 > --- a/drivers/video/fbdev/sis/init.c > +++ b/drivers/video/fbdev/sis/init.c > @@ -2649,7 +2649,7 @@ static void > SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo, > unsigned short ModeIdIndex, unsigned short RRTI) > { > - unsigned short data, infoflag = 0, modeflag, resindex; > + unsigned short data, infoflag = 0, modeflag; > #ifdef CONFIG_FB_SIS_315 > unsigned char *ROMAddr = SiS_Pr->VirtualRomBase; > unsigned short data2, data3; > @@ -2660,7 +2660,7 @@ SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo, > if(SiS_Pr->UseCustomMode) { > infoflag = SiS_Pr->CInfoFlag; > } else { > - resindex = SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex); > + SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex); Remove this whole line. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists