linux-kernel - Re: [PATCH] parisc: Remove sizeof(frame) from call to get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1404532702.6384.36.camel@joe-AO725>
Date:	Fri, 04 Jul 2014 20:58:22 -0700
From:	Joe Perches <joe@...ches.com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	jejb@...isc-linux.org, deller@....de, tiwai@...e.de,
	jkosina@...e.cz, dave.anglin@...l.net,
	linux-parisc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc: Remove sizeof(frame) from call to get_sigframe

On Fri, 2014-07-04 at 23:20 -0400, Nicholas Krause wrote:
> This removes the sizeof(frame) from the call to get_sigframe on line
> 243 in order to fix the call to this function as the sizeof in not
> needed to call this function.

How did you compile this?

arch/parisc/kernel/signal.c:178:get_sigframe(struct k_sigaction *ka, unsigned long sp, size_t frame_size)

> diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c
[]
> @@ -240,8 +240,7 @@ setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
[]
> -	/*FIXME: frame_size parameter is unused, remove it. */
> -	frame = get_sigframe(ka, usp, sizeof(*frame));
> +	frame = get_sigframe(ka, usp)

Nichola

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/