linux-kernel - Re: [PATCH] parisc: Remove sizeof(frame) from call to get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDOMVi+LZ_rMWwmvCBK_gwJw2SAZGeq+PtDu4T5Y+DF2iQxug@mail.gmail.com>
Date:	Sat, 5 Jul 2014 00:01:20 -0400
From:	Nick Krause <xerofoify@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	jejb@...isc-linux.org, deller@....de, tiwai@...e.de,
	Jiri Kosina <jkosina@...e.cz>, dave.anglin@...l.net,
	linux-parisc@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] parisc: Remove sizeof(frame) from call to get_sigframe

I didn't compile check it seems to be a valid line after reading this.
I will resend a new patch removing the FIX ME line.
Sorry Nick

On Fri, Jul 4, 2014 at 11:58 PM, Joe Perches <joe@...ches.com> wrote:
> On Fri, 2014-07-04 at 23:20 -0400, Nicholas Krause wrote:
>> This removes the sizeof(frame) from the call to get_sigframe on line
>> 243 in order to fix the call to this function as the sizeof in not
>> needed to call this function.
>
> How did you compile this?
>
> arch/parisc/kernel/signal.c:178:get_sigframe(struct k_sigaction *ka, unsigned long sp, size_t frame_size)
>
>> diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c
> []
>> @@ -240,8 +240,7 @@ setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
> []
>> -     /*FIXME: frame_size parameter is unused, remove it. */
>> -     frame = get_sigframe(ka, usp, sizeof(*frame));
>> +     frame = get_sigframe(ka, usp)
>
> Nichola
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/