linux-kernel - Re: [PATCH 05/18] power: reset: Add AT91 reset driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140708081259.GM13423@lukather>
Date:	Tue, 8 Jul 2014 10:12:59 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
Cc:	Boris BREZILLON <boris.brezillon@...e-electrons.com>,
	devicetree@...r.kernel.org, dbaryshkov@...il.com,
	Nicolas FERRE <nicolas.ferre@...el.com>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Thomas Petazzoni <thomas@...e-electrons.com>,
	Boris Brezillon <boris@...e-electrons.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	dwmw2@...radead.org, linux@...im.org.za,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 05/18] power: reset: Add AT91 reset driver

On Tue, Jul 08, 2014 at 10:08:14AM +0200, Maxime Ripard wrote:
> On Mon, Jul 07, 2014 at 08:40:01PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > > >> move this to an assembly file more easy to read than a C code
> > > > > > 
> > > > > > Nope. It's a pain to pass variable to an external assembly file, and
> > > > > > this makes the use of global variable pretty much mandatory, which is
> > > > > > definitely not great.
> > > > > 
> > > > > Not at all I did for the PM slow clock code just write a function and pas it as a parameter
> > > > > you have 3
> > > > > 
> > > > > so basically you have to use the current and just pass at91_ramc_base[0], at91_ramc_base[1]
> > > > > and at91_rstc_base
> > > > > it’s 3 lignes of modification, if you have at91_ramc_base and at91_ramc_base same
> > > > > 
> > > > 
> > > > Yes, retrieving function parameters from assembly code is not that
> > > > complicated (the first 4 pointer values are accessible through r0-r3),
> > > > but then you'll have to store your assembly file somewhere.
> > > 
> > > Like I was saying, there's a strong preference for the inline
> > > assembly...
> > 
> > inline is horrible to read and maintain NACK
> > 
> > keep it in an assembly file it's so easy to read and follow
> > 
> > and you just have to move the file existing to the driver/power
> 
> Well, the whole rest of the kernel community feels otherwise.

Thinking a bit more about this, would using symbolic names instead of
the indices in the inline assembly work for you?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)