linux-kernel - Re: [PATCH 1/8] Drivers: scsi: storvsc: Change the limits to reflect the values on the host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Jul 2014 01:39:54 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>
Cc:	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	ohering@...e.com, jbottomley@...allels.com, jasowang@...hat.com,
	apw@...onical.com, linux-scsi@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH 1/8] Drivers: scsi: storvsc: Change the limits to reflect
 the values on the host

On Tue, Jul 08, 2014 at 05:46:45PM -0700, K. Y. Srinivasan wrote:
> + * In Hyper-V, each port/path/target maps to 1 scsi host adapter.

Does it still?  The STORVSC_FC_MAX_TARGETS define suggests otherwise.

> -	.cmd_per_lun =		1,
> +	.cmd_per_lun =		255,

This looks like an unrelated change.

> +		/* max # of devices per target */
> +		host->max_lun = STORVSC_FC_MAX_LUNS_PER_TARGET;
> +		/* max # of targets per channel */
> +		host->max_id = STORVSC_FC_MAX_TARGETS;
> +		/* max # of channels */
> +		host->max_channel = STORVSC_FC_MAX_CHANNELS - 1;

I don't think these comments add any value..

Also any reason you use off by one defines for max_channel, but not the
others?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/