linux-kernel - Re: [PATCH 1/2] staging: silicom: checkpatch fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140709093808.GU25880@mwanda>
Date:	Wed, 9 Jul 2014 12:38:08 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Davide Gianforte <davide@...gisdave.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	kernel-janitors <kernel-janitors@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] staging: silicom: checkpatch fixes

The patch does too many things, break it up into one type of fix per
patch.

On Tue, Jul 01, 2014 at 02:24:36PM +0200, Davide Gianforte wrote:
> Chechpatch.pl cleanup
> 
> There are still some warnings, most of them are lines over 80 chars
> (mainly a semicolon or closing parenthesis).
> 
> Where not specified, I defaulted printk with no log level into pr_debug

No.  You can't just use pr_debug for everything.  Also some of them are
not whole line prints so the pr_debug() will put extra info in the
middle of the lines.

Write a hello_world.ko kernel module and play with the printk until you
understand what I mean.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/