linux-kernel - Re: [PATCH 2/2] staging: silicom: function return fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140709185914.GA28612@kroah.com>
Date:	Wed, 9 Jul 2014 11:59:14 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Davide Gianforte <davide@...gisdave.org>
Cc:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	kernel-janitors <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 2/2] staging: silicom: function return fixes

On Tue, Jul 01, 2014 at 02:33:43PM +0200, Davide Gianforte wrote:
> Function return fixes
> 
> Some functions don't need a temporary variable to store return value.
> 
> Where functions always return 0, changed into void functions.
> 
> Signed-off-by: Davide Gianforte <davide@...gisdave.org>
> --
> 
>  drivers/staging/silicom/bpctl_mod.c | 62 ++++++++++---------------------------
>  1 file changed, 16 insertions(+), 46 deletions(-)
> 
> diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c
> index 1322437..c9a4c40 100644
> --- a/drivers/staging/silicom/bpctl_mod.c
> +++ b/drivers/staging/silicom/bpctl_mod.c
> @@ -117,7 +117,7 @@ static struct bpctl_dev *get_status_port_fn(struct bpctl_dev *pbpctl_dev);
>  static void if_scan_init(void);
>  
>  static int bypass_proc_create_dev_sd(struct bpctl_dev *pbp_device_block);
> -static int bypass_proc_remove_dev_sd(struct bpctl_dev *pbp_device_block);
> +static void bypass_proc_remove_dev_sd(struct bpctl_dev *pbp_device_block);
>  
>  static int is_bypass_fn(struct bpctl_dev *pbpctl_dev);
>  static int get_dev_idx_bsf(int bus, int slot, int func);
> @@ -1458,9 +1458,8 @@ static int send_wdt_pulse(struct bpctl_dev *pbpctl_dev)
>  static void send_bypass_clear_pulse(struct bpctl_dev *pbpctl_dev,
>  				    unsigned int value)
>  {
> -	uint32_t ctrl_ext = 0;
> +	uint32_t ctrl_ext = BPCTL_READ_REG(pbpctl_dev, CTRL_EXT);
>  
> -	ctrl_ext = BPCTL_READ_REG(pbpctl_dev, CTRL_EXT);

How about just removing the " = 0;" part of the variable definition?
That would be a smaller patch, and still keep everything "clean".

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/