linux-kernel - Re: [PATCH 06/14] cpufreq: cpu0: defer probe if clock isn't registered yet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53BD5523.2080404@ti.com>
Date:	Wed, 9 Jul 2014 10:43:47 -0400
From:	Santosh Shilimkar <santosh.shilimkar@...com>
To:	Viresh Kumar <viresh.kumar@...aro.org>,
	Stephen Boyd <sboyd@...eaurora.org>
CC:	Nishanth Menon <nm@...com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>, Tomasz Figa <t.figa@...sung.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Lists linaro-kernel <linaro-kernel@...ts.linaro.org>,
	Thomas P Abraham <thomas.ab@...sung.com>,
	Arvind Chauhan <arvind.chauhan@....com>,
	Sachin Kamat <spk.linux@...il.com>
Subject: Re: [PATCH 06/14] cpufreq: cpu0: defer probe if clock isn't registered
 yet

On Wednesday 02 July 2014 10:19 PM, Viresh Kumar wrote:
> On 3 July 2014 06:08, Stephen Boyd <sboyd@...eaurora.org> wrote:
>> Please make this a dev_dbg() or just remove it entirely. Sending a
>> message to the log on probe defer just duplicates what the driver core
>> is already doing.
> 
> Updated as:
> 
> Author: Viresh Kumar <viresh.kumar@...aro.org>
> Date:   Thu Jun 26 10:40:21 2014 +0530
> 
>     cpufreq: cpu0: print relevant error when we defer probe
> 
>     Currently, we defer probe if regulator_get() returned -EPROBE_DEFER, i.e.
>     regulator isn't registered yet. We do a dev_err() in this case. Sending a
>     message to the log on probe defer just duplicates what the driver core is
>     already doing. Convert it to dev_dbg() instead.
> 
>     We should defer in case of clk_get() as well.
> 
>     Current code already does it, but it wasn't intentional probably.
> Its just that
>     we are returning the right error with wrong print message.
> 
>     Fix print message to convey right error.
> 
>     Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
>  drivers/cpufreq/cpufreq-cpu0.c | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
Looks good to me.
Acked-by: Santosh Shilimkar <santosh.shilimkar@...com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/