linux-kernel - Re: [PATCH 07/14] cpufreq: cpu0: OPPs can be populated at runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53BD5564.2060704@ti.com>
Date:	Wed, 9 Jul 2014 10:44:52 -0400
From:	Santosh Shilimkar <santosh.shilimkar@...com>
To:	Viresh Kumar <viresh.kumar@...aro.org>, <rjw@...ysocki.net>,
	<shawn.guo@...aro.org>
CC:	<nm@...com>, <linaro-kernel@...ts.linaro.org>,
	<linux-pm@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
	<t.figa@...sung.com>, <sboyd@...eaurora.org>,
	<linux-kernel@...r.kernel.org>, <thomas.ab@...sung.com>,
	<arvind.chauhan@....com>, <spk.linux@...il.com>
Subject: Re: [PATCH 07/14] cpufreq: cpu0: OPPs can be populated at runtime

On Tuesday 01 July 2014 12:32 PM, Viresh Kumar wrote:
> OPPs can be populated statically, via DT, or added at run time with
> dev_pm_opp_add().
> 
> While this driver handles the first case correctly, it would fail to populate
> OPPs added at runtime. Because call to of_init_opp_table() would fail as there
> are no OPPs in DT and probe will return early.
> 
> To fix this, remove error checking and call dev_pm_opp_init_cpufreq_table()
> unconditionally.
> 
> Suggested-by: Stephen Boyd <sboyd@...eaurora.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
Assuming you are updating bidnings as suggested by Stephen,
patch looks good to me.
Acked-by: Santosh Shilimkar <santosh.shilimkar@...com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/