linux-kernel - Re: [PATCH net-next 1/3 v4] pktgen: Fill the payload optionally with a pattern

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53BD56F6.3060407@citrix.com>
Date:	Wed, 9 Jul 2014 15:51:34 +0100
From:	Zoltan Kiss <zoltan.kiss@...rix.com>
To:	David Miller <davem@...emloft.net>
CC:	<steffen.klassert@...unet.com>, <minipli@...glemail.com>,
	<dborkman@...hat.com>, <tgraf@...g.ch>, <joe@...ches.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<xen-devel@...ts.xenproject.org>
Subject: Re: [PATCH net-next 1/3 v4] pktgen: Fill the payload optionally with
 a pattern

On 08/07/14 19:28, David Miller wrote:
> From: Zoltan Kiss <zoltan.kiss@...rix.com>
> Date: Wed, 2 Jul 2014 20:54:13 +0100
>
>> @@ -1129,11 +1133,13 @@ static ssize_t pktgen_if_write(struct file *file,
>>   		i += len;
>>
>>   		if (node_possible(value)) {
>> +			int j;
>>   			pkt_dev->node = value;
>>   			sprintf(pg_result, "OK: node=%d", pkt_dev->node);
>> -			if (pkt_dev->page) {
>> -				put_page(pkt_dev->page);
>> -				pkt_dev->page = NULL;
>> +			for (j = 0; j < MAX_SKB_FRAGS; ++j)
>> +				if (pkt_dev->pages[j]) {
>> +					put_page(pkt_dev->pages[j]);
>> +					pkt_dev->pages[j] = NULL;
>>   			}
>>   		}
>
> I'm scratching my head with the bracing created here, and it's because
> the indentation is wrong:
>
> 	for () /* <-- no openning curly brace */
> 		if () {
> 			x;
> 			y;
> 	} /* <-- thus, wrong indentation */

Hm, checkpatch couldn't catch this, I'll report it to the maintainers.

Zoli

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/