linux-kernel - checkpatch minor issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53BD5921.4050405@citrix.com>
Date:	Wed, 9 Jul 2014 16:00:49 +0100
From:	Zoltan Kiss <zoltan.kiss@...rix.com>
To:	Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...onical.com>
CC:	David Miller <davem@...emloft.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: checkpatch minor issue

Hi,

In one of my posted patch David spotted an indentation error, I thought 
these trivial mistakes are catched by checkpatch. Maybe it shouldn't, 
but otherwise you should check this issue, see it in the mail below.

Regards,

Zoli

-------- Original Message --------
Subject: Re: [PATCH net-next 1/3 v4] pktgen: Fill the payload optionally 
with a pattern
Date: Tue, 8 Jul 2014 11:28:38 -0700
From: David Miller <davem@...emloft.net>
To: <zoltan.kiss@...rix.com>
CC: <steffen.klassert@...unet.com>, <minipli@...glemail.com>, 
<dborkman@...hat.com>, <tgraf@...g.ch>, <joe@...ches.com>, 
<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, 
<xen-devel@...ts.xenproject.org>

From: Zoltan Kiss <zoltan.kiss@...rix.com>
Date: Wed, 2 Jul 2014 20:54:13 +0100

> @@ -1129,11 +1133,13 @@ static ssize_t pktgen_if_write(struct file *file,
>  		i += len;
>
>  		if (node_possible(value)) {
> +			int j;
>  			pkt_dev->node = value;
>  			sprintf(pg_result, "OK: node=%d", pkt_dev->node);
> -			if (pkt_dev->page) {
> -				put_page(pkt_dev->page);
> -				pkt_dev->page = NULL;
> +			for (j = 0; j < MAX_SKB_FRAGS; ++j)
> +				if (pkt_dev->pages[j]) {
> +					put_page(pkt_dev->pages[j]);
> +					pkt_dev->pages[j] = NULL;
>  			}
>  		}

I'm scratching my head with the bracing created here, and it's because
the indentation is wrong:

	for () /* <-- no openning curly brace */
		if () {
			x;
			y;
	} /* <-- thus, wrong indentation */

Please resubmit this series with this fixed and #3 adjusted as per the
feedback you've received.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/