linux-kernel - Re: [PATCH] drivers: staging: android: ion: Kconfig: Let it also depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMbhsRQpRhCAYrJbT5E6H3Pn6SvDRUFL6Rwq9gjkxv_gB0D-ZQ@mail.gmail.com>
Date:	Wed, 9 Jul 2014 11:23:34 -0700
From:	Colin Cross <ccross@...roid.com>
To:	Chen Gang <gang.chen.5i5j@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	John Stultz <john.stultz@...aro.org>,
	Rebecca Zavin <rebecca@...roid.com>,
	Liqin Chen <liqin.linux@...il.com>,
	Lennox Wu <lennox.wu@...il.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: staging: android: ion: Kconfig: Let it also
 depend on HAS_DMA

On Mon, Jul 7, 2014 at 1:49 AM, Chen Gang <gang.chen.5i5j@...il.com> wrote:
> ION need HAS_DMA (e.g. need DMA_SHARED_BUFFER), so it has to depend on
> HAS_DMA, or can not pass compiling with allmodconfig under score which
> NO_DMA.  And the related error:
>
>     CC      drivers/staging/android/ion/ion_cma_heap.o
>   drivers/staging/android/ion/ion_cma_heap.c: In function 'ion_cma_mmap':
>   drivers/staging/android/ion/ion_cma_heap.c:168:2: error: implicit declaration of function 'dma_mmap_coherent' [-Werror=implicit-function-declaration]
>     return dma_mmap_coherent(dev, vma, info->cpu_addr, info->handle,
>     ^
>   cc1: some warnings being treated as errors
>   make[4]: *** [drivers/staging/android/ion/ion_cma_heap.o] Error 1
>   make[3]: *** [drivers/staging/android/ion] Error 2
>   make[2]: *** [drivers/staging/android] Error 2
>   make[1]: *** [drivers/staging] Error 2
>   make: *** [drivers] Error 2
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> ---
>  drivers/staging/android/ion/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
> index 0f8fec1..0a6e4d0 100644
> --- a/drivers/staging/android/ion/Kconfig
> +++ b/drivers/staging/android/ion/Kconfig
> @@ -1,6 +1,6 @@
>  menuconfig ION
>         bool "Ion Memory Manager"
> -       depends on HAVE_MEMBLOCK
> +       depends on HAVE_MEMBLOCK && HAS_DMA
>         select GENERIC_ALLOCATOR
>         select DMA_SHARED_BUFFER
>         ---help---
> --
> 1.9.2.459.g68773ac

Acked-by: Colin Cross <ccross@...roid.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/