linux-kernel - Re: [PATCH V2] staging: gdm72xx: move T

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53BD88C5.90606@fastmail.fm>
Date:	Wed, 09 Jul 2014 19:24:05 +0100
From:	Michalis Pappas <mpappas@...tmail.fm>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] staging: gdm72xx: move T_CAPABILITY definitions to
 hci.h

On 07/09/2014 11:26 AM, Dan Carpenter wrote:
>>  	/* GetInformation mac address */
>>  	len = 0;
>> @@ -621,12 +618,12 @@ static void gdm_wimax_prepare_device(struct net_device *dev)
>>  	hci->length = H2B(len);
>>  	gdm_wimax_send(nic, hci, HCI_HEADER_SIZE+len);
>>  
>> -	val = (1<<BIT_WIMAX) | (1<<BIT_MULTI_CS);
>> +	val = (1 << T_CAPABILITY_WIMAX) | (1 << T_CAPABILITY_MULTI_CS);
> 
> Double shifting here...  It should just be:
> 
> 	val = T_CAPABILITY_WIMAX | T_CAPABILITY_MULTI_CS;
> 

Ooops! Thanks for spotting that, will submit a corrected patch.

M.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/