lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 9 Jul 2014 12:02:00 -0700
From:	Greg KH <>
To:	Daeseok Youn <>
Subject: Re: [PATCH] staging: dgap: removes redundant null check and change
 paramter for dgap_maxcps_room()

On Mon, Jul 07, 2014 at 10:27:54AM +0900, Daeseok Youn wrote:
> Null checks for tty, un and ch are already done by caller,
> so replace parameter "tty" with "ch" and "un".
> And also use a pointer for returning new bytes_available instead of
> return variable.

Why make that change?  It's nicer to return a real value where ever
possible.  That's more like other "room" functions in the tty layer.

Care to fix this up to just do the first change you made to the function


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists