linux-kernel - RE: [PATCH v3 4/4] staging: rtl8192u: Fixed too long lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <FDC088D3B5555644AE135ED28A7ABDE938EFFA81@EU-MBX-04.mgc.mentorg.com>
Date:	Thu, 10 Jul 2014 12:18:42 +0000
From:	"Sharma, Sanjeev" <Sanjeev_Sharma@...tor.com>
To:	Joe Perches <joe@...ches.com>,
	sanjeev sharma <sanjeevsharmaengg@...il.com>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"rmfrfs@...il.com" <rmfrfs@...il.com>,
	"peter.senna@...il.com" <peter.senna@...il.com>,
	"teobaluta@...il.com" <teobaluta@...il.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 4/4] staging: rtl8192u: Fixed too long lines

Hi Joe,

I have incorporated your review comment  in version v4.

Regards
Sanjeev Sharma 

-----Original Message-----
From: Joe Perches [mailto:joe@...ches.com] 
Sent: Wednesday, July 09, 2014 6:27 PM
To: sanjeev sharma
Cc: gregkh@...uxfoundation.org; rmfrfs@...il.com; peter.senna@...il.com; teobaluta@...il.com; devel@...verdev.osuosl.org; linux-kernel@...r.kernel.org; Sharma, Sanjeev
Subject: Re: [PATCH v3 4/4] staging: rtl8192u: Fixed too long lines

On Wed, 2014-07-09 at 17:49 +0530, sanjeev sharma wrote:
> This patch will fix too long lines warning reported by checkpatch.pl.

Hi Sanjeev.

> diff --git a/drivers/staging/rtl8192u/r819xU_phy.c 
> b/drivers/staging/rtl8192u/r819xU_phy.c
[]
> @@ -1786,7 +1788,9 @@ void InitialGainOperateWorkItemCallBack(struct work_struct *work)
>  		RT_TRACE(COMP_SCAN, "Scan BBInitialGainRestore 0xa0a is %x\n",
>  			 priv->initgain_backup.cca);
>  
> -		rtl8192_phy_setTxPower(dev, priv->ieee80211->current_network.channel);
> +		rtl8192_phy_setTxPower(dev,
> +					priv->ieee80211->current_network.channel
> +				       );

This one is a little off

+		rtl8192_phy_setTxPower(dev,
+					priv->ieee80211->current_network.channel
+				       );

Please align multiline statements to the appropriate open parenthesis using a mix of initial leading tabs followed by the minimal number of spaces required to put the first non-whitespace char at the column immediately after the preceding open paren.

Here it's 4 tabs, 7 spaces, not 5 tabs:

+		rtl8192_phy_setTxPower(dev,
+				       priv->ieee80211->current_network.channel);

And please don't use a line that's just a close parenthesis and semicolon.

I think it's better to ignore the 80 column limit for these and place them at the end of the preceding line.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/