linux-kernel - Re: [PATCH v7 10/33] net: dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG-2HqVOviqCYrKL-F3o_cR66EAe2skbL20pR48CmEikG1o-7g@mail.gmail.com>
Date:	Thu, 10 Jul 2014 14:18:32 +0200
From:	Tom Gundersen <teg@...m.no>
To:	Bjørn Mork <bjorn@...k.no>
Cc:	netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	David Herrmann <dh.herrmann@...il.com>,
	Kay Sievers <kay@...y.org>,
	dingtianhong <dingtianhong@...wei.com>,
	Tan Xiaojun <tanxiaojun@...wei.com>,
	WANG Cong <xiyou.wangcong@...il.com>
Subject: Re: [PATCH v7 10/33] net: dummy - set name assign type

On Thu, Jul 10, 2014 at 1:44 PM, Bjørn Mork <bjorn@...k.no> wrote:
> Tom Gundersen <teg@...m.no> writes:
>
>> The result of
>>
>> modprobe dummy numdummies=2
>>
>> is to create dummy0 and dummy1, always with the same names.
>>
>> The result of
>>
>> ip link add type dummy
>>
>> is to create dummyX, where X depends on what came before.
>
> Which is no different. That's exacly what happens when
> "modprobe dummy numdummies=2" creates the two first interfaces.
>
>
>  ip link add link wwan0 name dummy0 type vlan id 2
>  modprobe dummy numdummies=2
>
> ends up with dummy1 and dummy2 created by the dummy driver.
>
> You are trying to make up differences that just aren't there.

Ah, good point. You are right. So the dummy interfaces should be
labelled NET_NAME_ENUM.

I suppose the distinction should be that statically created devices
like these should be NET_NAME_PREDICTABLE only if they fail when the
name they want is already taken (rather than just picking the next
one).

Thanks for looking into this!

Cheers,

Tom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/