linux-kernel - Re: [PATCH 00/16] i2c: drop class based instantiaion for selected drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140710131307.GI2728@katana>
Date:	Thu, 10 Jul 2014 15:13:07 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Lothar Waßmann <LW@...O-electronics.de>
Cc:	linux-i2c@...r.kernel.org,
	davinci-linux-open-source@...ux.davincidsp.com,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	adi-buildroot-devel@...ts.sourceforge.net,
	linux-tegra@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 00/16] i2c: drop class based instantiaion for selected
 drivers


> > +	/* Warn that the adapter lost class based instantiation */
> > +	if (adapter->class == I2C_CLASS_DEPRECATED) {
> > +		dev_dbg(&adapter->dev,
> > +			"This adapter dropped support for I2C classes and "
> > +			"won't auto-detect %s devices anymore. If you need it, check "
> > +			"'Documentation/i2c/instantiating-devices' for alternatives.\n",
> >
> It's usually a bad idea to split kernel messages across source lines

Yes, "usually". Not for this message, though, it's specific. The lines
would have been quite long.

> You could at least do the split at the sentence boundary.

OK, this would have been a compromise.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)