linux-kernel - Re: [PATCH] coredump: Fix the setting of PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140711103510.GA2252@redhat.com>
Date:	Fri, 11 Jul 2014 12:35:10 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Silesh C V <svellattu@...sta.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Mandeep Singh Baines <msb@...omium.org>
Subject: Re: [PATCH] coredump: Fix the setting of PF_DUMPCORE

OOPS. Thanks a lot Silesh.

Hopefully Andrew can take this patch. And it probably needs
Cc: stable@...r.kernel.org # v3.10+

On 07/11, Silesh C V wrote:
>
> commit 079148b91 (coredump: factor out the setting of PF_DUMPCORE)
> cleaned up the setting of PF_DUMPCORE by removing it from all the
> linux_binfmt->core_dump() and moving it to zap_threads().But this
> ended up clearing all the previously set flags. This causes issues
> during core generation when tsk->flags is checked again
> (eg. for PF_USED_MATH to dump floating point registers). Fix this.
> 
> Signed-off-by: Silesh C V <svellattu@...sta.com>
> Cc: Oleg Nesterov <oleg@...hat.com>
> Cc: Mandeep Singh Baines <msb@...omium.org>
> 
> ---
>  fs/coredump.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/coredump.c b/fs/coredump.c
> index 0b2528f..a93f7e6 100644
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -306,7 +306,7 @@ static int zap_threads(struct task_struct *tsk, struct mm_struct *mm,
>  	if (unlikely(nr < 0))
>  		return nr;
>  
> -	tsk->flags = PF_DUMPCORE;
> +	tsk->flags |= PF_DUMPCORE;
>  	if (atomic_read(&mm->mm_users) == nr + 1)
>  		goto done;
>  	/*
> -- 
> 1.8.1.2
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/