linux-kernel - Re: [PATCH 2/2] clk: exynos-audss: Update as per existing framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <53BFBF18.3080704@samsung.com>
Date:	Fri, 11 Jul 2014 12:40:24 +0200
From:	Sylwester Nawrocki <s.nawrocki@...sung.com>
To:	Tushar Behera <tushar.b@...sung.com>
Cc:	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	robh+dt@...nel.org, grant.likely@...aro.org, kgene.kim@...sung.com,
	mturquette@...aro.org, t.figa@...sung.com, trblinux@...il.com
Subject: Re: [PATCH 2/2] clk: exynos-audss: Update as per existing framework

Hi Tushar,

On 11/07/14 11:37, Tushar Behera wrote:
> Change exynos-audss clock driver as per existing clock framework from
> the existing module driver framework.

Can you explain what's the actual issue you're trying to solve with that
patch ? What's the problem with this driver being a platform driver ?
It feels we're moving in circles here, see

commit b37a4224104568198b93fb9831224cfe7d83fff8
Author: Andrew Bresticker <abrestic@...omium.org>
Date:   Wed Sep 25 14:12:47 2013 -0700

    clk: exynos-audss: convert to platform device

    The Exynos AudioSS clock controller will later be modified to allow
    input clocks to be specified via device-tree in order to support
    multiple Exynos SoCs.  This will introduce a dependency on the core
    SoC clock controller being initialized first so that the AudioSS driver
    can look up its input clocks, but the order in which clock providers
    are probed in of_clk_init() is not guaranteed.  Since deferred probing
    is not supported in of_clk_init() and the AudioSS block is not the core
    controller, we can initialize it later as a platform device.

    Signed-off-by: Andrew Bresticker <abrestic@...omium.org>
    Acked-by: Tomasz Figa <t.figa@...sung.com>
    Reviewed-by: Sylwester Nawrocki <s.nawrocki@...sung.com>
    Acked-by: Mike Turquette <mturquette@...aro.org>
    Acked-by: Kukjin Kim <kgene.kim@...sung.com>
    Signed-off-by: Tomasz Figa <t.figa@...sung.com>

I realize of_clk_init() now handles better clock provider dependencies,
nevertheless do we really need all this churn ?

--
Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/