linux-kernel - RE: [RESEND][PATCH 06/10][SCSI]mpt2sas: For >2TB volumes, DirectDrive support sends IO's with LBA bit 31 to IR FW instead of DirectDrive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <94D0CD8314A33A4D9D801C0FE68B402958BA02C2@G9W0745.americas.hpqcorp.net>
Date:	Sun, 13 Jul 2014 17:02:21 +0000
From:	"Elliott, Robert (Server Storage)" <Elliott@...com>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	"Reddy, Sreekanth" <Sreekanth.Reddy@...gotech.com>
CC:	"jejb@...nel.org" <jejb@...nel.org>,
	"JBottomley@...allels.com" <JBottomley@...allels.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"Sathya.Prakash@...gotech.com" <Sathya.Prakash@...gotech.com>,
	"Nagalakshmi.Nandigama@...gotech.com" 
	<Nagalakshmi.Nandigama@...gotech.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"hch@...radead.org" <hch@...radead.org>
Subject: RE: [RESEND][PATCH 06/10][SCSI]mpt2sas: For >2TB volumes,
 DirectDrive support sends IO's with LBA bit 31 to IR FW instead of
 DirectDrive



> -----Original Message-----
> From: linux-scsi-owner@...r.kernel.org [mailto:linux-scsi-
> owner@...r.kernel.org] On Behalf Of Martin K. Petersen


...
> Also, this is not touched by the patch, but you're then doing:
> 
>         (*(__be32 *)(&cdb_ptr[i])) = cpu_to_be32(p_lba);
> 
> What if this is a 6-byte READ/WRITE command? You'll end up exceeding the
> size of the LBA field.

All this is inside:
        if (cdb0 == READ_16 || cdb0 == READ_10 ||
            cdb0 == WRITE_16 || cdb0 == WRITE_10) {

so READ_6 and WRITE_6 and all their oddities are not a problem here.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/