linux-kernel - Re: [PATCH v2 02/15] ARM: pass IRQ domain to the core IRQ handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140713224831.GJ13108@titan.lakedaemon.net>
Date:	Sun, 13 Jul 2014 18:48:31 -0400
From:	Jason Cooper <jason@...edaemon.net>
To:	Marc Zyngier <marc.zyngier@....com>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Russell King <linux@....linux.org.uk>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Alexander Shiyan <shc_work@...l.ru>,
	Barry Song <baohua@...nel.org>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Kevin Hilman <khilman@...aro.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
	Larry Bassel <larry.bassel@...aro.org>,
	Mark Rutland <mark.rutland@....com>,
	Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH v2 02/15] ARM: pass IRQ domain to the core IRQ handler

Marc,

On Tue, Jul 08, 2014 at 02:45:40PM +0100, Marc Zyngier wrote:
> Calling irq_find_mapping from outside a irq_{enter,exit} section is
> unsafe and produces ugly messages if CONFIG_PROVE_RCU is enabled:
> If coming from the idle state, the rcu_read_lock call in irq_find_mapping
> will generate an an unpleasant warning.
> 
> A solution is to add a new handle_domain_irq entry point into
> the arm code that the interrupt controller code can call.
> This new function takes an irq_domain, and calls into irq_find_domain
> inside the irq_{enter,exit} block.
> 
> Interrupt controllers can then be updated to use the new mechanism.
> 
> Signed-off-by: Marc Zyngier <marc.zyngier@....com>
> ---
> Sending the right patch this time, with the missing includes that would
> otherwise break the build...
> 
>  arch/arm/include/asm/irq.h |  2 ++
>  arch/arm/kernel/irq.c      | 25 +++++++++++++++++++++----
>  2 files changed, 23 insertions(+), 4 deletions(-)

Please place in Russell's patch tracker,

Acked-by: Jason Cooper <jason@...edaemon.net>

Once it lands in a release, we'll apply the rest.  Please send me a
gentle reminder ;-)

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/