linux-kernel - Re: [PATCH 13/83] hsa/radeon: Add 2 new IOCTL to kfd, CREATE_QUEUE and DESTROY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <019CCE693E457142B37B791721487FD9180B19A2@storexdag03.amd.com>
Date:	Mon, 14 Jul 2014 07:33:47 +0000
From:	"Gabbay, Oded" <Oded.Gabbay@....com>
To:	"airlied@...il.com" <airlied@...il.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"j.glisse@...il.com" <j.glisse@...il.com>,
	"Bridgman, John" <John.Bridgman@....com>,
	"Deucher, Alexander" <Alexander.Deucher@....com>,
	"Lewycky, Andrew" <Andrew.Lewycky@....com>,
	"linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
	"joro@...tes.org" <joro@...tes.org>,
	"Pinchuk, Evgeny" <Evgeny.Pinchuk@....com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"Skidanov, Alexey" <Alexey.Skidanov@....com>,
	"airlied@...ux.ie" <airlied@...ux.ie>,
	"oded.gabbay@...il.com" <oded.gabbay@...il.com>,
	"Goz, Ben" <Ben.Goz@....com>
Subject: Re: [PATCH 13/83] hsa/radeon: Add 2 new IOCTL to kfd, CREATE_QUEUE
 and DESTROY_QUEUE

On Sat, 2014-07-12 at 07:42 +1000, Dave Airlie wrote:
> >  +/* The 64-bit ABI is the authoritative version. */
> >  +#pragma pack(push, 8)
> >  +
>  
> Don't do this, pad and align things explicitly in structs.
>  
> >  +struct kfd_ioctl_create_queue_args {
> >  +       uint64_t ring_base_address;     /* to KFD */
> >  +       uint32_t ring_size;             /* to KFD */
> >  +       uint32_t gpu_id;                /* to KFD */
> >  +       uint32_t queue_type;            /* to KFD */
> >  +       uint32_t queue_percentage;      /* to KFD */
> >  +       uint32_t queue_priority;        /* to KFD */
> >  +       uint64_t write_pointer_address; /* to KFD */
> >  +       uint64_t read_pointer_address;  /* to KFD */
> >  +
> >  +       uint64_t doorbell_address;      /* from KFD */
> >  +       uint32_t queue_id;              /* from KFD */
> >  +};
> >  +
>  
> maybe put all the uint64_t at the start, or add explicit padding.
>  
> Dave.
Thanks, will be fixed.
        Oded