lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 Jul 2014 11:43:24 +0530 From: Viresh Kumar <viresh.kumar@...aro.org> To: Saravana Kannan <skannan@...eaurora.org> Cc: "Rafael J . Wysocki" <rjw@...ysocki.net>, Todd Poynor <toddpoynor@...gle.com>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Stephen Boyd <sboyd@...eaurora.org> Subject: Re: [PATCH v2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend On 12 July 2014 08:36, Saravana Kannan <skannan@...eaurora.org> wrote: > On 07/10/2014 11:19 PM, Viresh Kumar wrote: > >> >> Please make sure you take care of these issues: >> - suspend/resume >> - hotplug >> - module insert/remove > > Ok, I was just at the current code. Does cpufreq_unregister_driver() even > really work correctly as it stands? > > It doesn't even seem to stop any of the governors/policies before it just > set the cpufreq_driver pointer to NULL. > > So, technically my v2 patch doesn't even make anything worse when it comes > to unregistering the cpufreq driver. Are you really sure about this? I have tested this *myself* earlier.. subsys_interface_unregister() should take care of stopping/freeing governor stuff.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists