linux-kernel - Re: [PATCH] vfs: Turn the unlinked inode counter into a percpu counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140714154930.GB5803@tassilo.jf.intel.com>
Date:	Mon, 14 Jul 2014 08:49:30 -0700
From:	Andi Kleen <ak@...ux.intel.com>
To:	Lukáš Czerner <lczerner@...hat.com>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>,
	Miklos Szeredi <mszeredi@...e.cz>
Subject: Re: [PATCH] vfs: Turn the unlinked inode counter into a percpu
 counter

> > diff --git a/fs/inode.c b/fs/inode.c
> > index f96d2a6..4820c35 100644
> > --- a/fs/inode.c
> > +++ b/fs/inode.c
> > @@ -234,10 +234,8 @@ void __destroy_inode(struct inode *inode)
> >  	BUG_ON(inode_has_buffers(inode));
> >  	security_inode_free(inode);
> >  	fsnotify_inode_delete(inode);
> > -	if (!inode->i_nlink) {
> > -		WARN_ON(atomic_long_read(&inode->i_sb->s_remove_count) == 0);
> 
> This is not mentioned in the description, but I guess it makes sense since
> it'd be quite expensive.

Yes. I guess we could still check the local counter. I can re-add that.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/