linux-kernel - Re: [PATCH 1/7] tracing: instance_rmdir() leaks ftrace_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140714190323.GA19996@redhat.com>
Date:	Mon, 14 Jul 2014 21:03:23 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Tom Zanussi <tom.zanussi@...ux.intel.com>,
	"zhangwei(Jovi)" <jovi.zhangwei@...wei.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] tracing: instance_rmdir() leaks
	ftrace_event_file->filter

On 07/14, Steven Rostedt wrote:
>
> On Fri, 11 Jul 2014 21:06:38 +0200
> Oleg Nesterov <oleg@...hat.com> wrote:
>
> > @@ -470,6 +470,7 @@ static void remove_event_file_dir(struct ftrace_event_file *file)
> >
> >  	list_del(&file->list);
> >  	remove_subsystem(file->system);
> > +	free_event_filter(file->filter);
> >  	kmem_cache_free(file_cachep, file);
> >  }
> >
>
> Thanks, looks like this goes back to 3.11. I'll start testing this and
> get it out for stable as well.

Thanks.

Just in case: sorry, I was distracted once again and didn't test 2-7 yet.
Although everything looks simple, even 7/7. But it needs v2 anyway, as
Namhyung pointed out this patch can also change replace_system_preds()
the same way.

Hopefully I'll do this tomorrow, but your review is needed anyway ;)

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/