linux-kernel - Re: [PATCH 6/7] tracing: kill ftrace_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140714150624.32f49b7d@gandalf.local.home>
Date:	Mon, 14 Jul 2014 15:06:24 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Tom Zanussi <tom.zanussi@...ux.intel.com>,
	"zhangwei(Jovi)" <jovi.zhangwei@...wei.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] tracing: kill ftrace_event_call->files

On Fri, 11 Jul 2014 21:06:53 +0200
Oleg Nesterov <oleg@...hat.com> wrote:

> Remove ftrace_event_call->files. It has no users, and in fact even
> the commit ae63b31e4d0e "tracing: Separate out trace events from
> global variables" which added this member did not use it.
> 

Ouch!

OK, I swear I used it before I committed the change. I just stopped
using it before I committed the change as well.

-- Steve

> Signed-off-by: Oleg Nesterov <oleg@...hat.com>
> ---
>  include/linux/ftrace_event.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h
> index f434d75..06c6faa 100644
> --- a/include/linux/ftrace_event.h
> +++ b/include/linux/ftrace_event.h
> @@ -272,7 +272,6 @@ struct ftrace_event_call {
>  	struct trace_event	event;
>  	const char		*print_fmt;
>  	struct event_filter	*filter;
> -	struct list_head	*files;
>  	void			*mod;
>  	void			*data;
>  	/*

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/