lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140714190355.GA16904@gmail.com> Date: Mon, 14 Jul 2014 21:04:26 +0200 From: Beniamino Galvani <b.galvani@...il.com> To: Heiko Stübner <heiko@...ech.de> Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [PATCH] ARM: dts: rk3188-radxarock: add GPIO IR receiver node On Sun, Jul 13, 2014 at 02:37:40PM +0200, Heiko Stübner wrote: > Am Sonntag, 13. Juli 2014, 14:10:01 schrieb Beniamino Galvani: > > This adds a device tree node for the infrared receiver connected to a > > GPIO pin on the Radxa Rock. > > > > Signed-off-by: Beniamino Galvani <b.galvani@...il.com> > > --- > > arch/arm/boot/dts/rk3188-radxarock.dts | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts > > b/arch/arm/boot/dts/rk3188-radxarock.dts index 19d45b4..1d87bcb 100644 > > --- a/arch/arm/boot/dts/rk3188-radxarock.dts > > +++ b/arch/arm/boot/dts/rk3188-radxarock.dts > > @@ -23,6 +23,13 @@ > > reg = <0x60000000 0x80000000>; > > }; > > > > + ir_recv: ir-receiver { > > + compatible = "gpio-ir-receiver"; > > + gpios = <&gpio0 10 1>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&ir_recv_pin>; > > + }; > > + > > hmm, on second glance, I'm actually not sure if this shouldn't belong in the > soc subnode, like the gpio-keys and leds. (adding devicetree mailing list) I placed the IR receiver under the root node after looking at what other boards do, for example: imx6dl-hummingboard.dts imx6qdl-cubox-i.dtsi dove-cubox.dts On the other hand, if gpio-keys and leds are under the soc node probably it makes sense to follow the same rule also for the IR receiver. Beniamino -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists