linux-kernel - Re: [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Jul 2014 11:16:48 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	sam-the-6 <asadi.samuel@...il.com>, <hsweeten@...ionengravers.com>,
	<gregkh@...uxfoundation.org>
CC:	<devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return'
 from generic func

On 2014-07-15 04:13, sam-the-6 wrote:
> From: Sam Asadi <asadi.samuel@...il.com>
>
> Signed-off-by: Sam Asadi <asadi.samuel@...il.com>
>
> 	modified:   drivers/staging/comedi/drivers/8253.h
> ---
>   drivers/staging/comedi/drivers/8253.h |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/8253.h b/drivers/staging/comedi/drivers/8253.h
> index 5829b46..f6b8607 100644
> --- a/drivers/staging/comedi/drivers/8253.h
> +++ b/drivers/staging/comedi/drivers/8253.h
> @@ -55,7 +55,7 @@ static inline void i8253_cascade_ns_to_timer(int i8253_osc_base,
>   	    /* check for overflow */
>   	    divider > div1 && divider > div2 &&
>   	    divider * i8253_osc_base > divider &&
> -	    divider * i8253_osc_base > i8253_osc_base) {
> +	    divider * i8253_osc_base > i8253_osc_base)	{

Keep the space before the '{'.  Don't replace it with a tab.

>   		return;
>   	}
>
> @@ -118,7 +118,6 @@ static inline void i8253_cascade_ns_to_timer(int i8253_osc_base,
>   	/*  masking is done since counter maps zero to 0x10000 */
>   	*d1 = div1 & 0xffff;
>   	*d2 = div2 & 0xffff;
> -	return;
>   }
>
>   #ifndef CMDTEST
>


-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/