linux-kernel - Re: [PATCH net-next] virtio-net: rx busy polling support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1405419703.10255.26.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 15 Jul 2014 12:21:43 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jason Wang <jasowang@...hat.com>
Cc:	rusty@...tcorp.com.au, mst@...hat.com,
	virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Vlad Yasevich <vyasevic@...hat.com>
Subject: Re: [PATCH net-next] virtio-net: rx busy polling support

On Tue, 2014-07-15 at 17:41 +0800, Jason Wang wrote:
> Add basic support for rx busy polling.
> 
> 1 byte netperf tcp_rr on mlx4 shows 116% improvement: the transaction
> rate was increased from 9151.94 to 19787.37.

This is a misleading changelog.

You forgot to describe how you allowed busy polling, as it is not
'automatic'

If not, this patch adds two spinlock/unlock pairs in fast path.

Also, it looks like you could split this in smaller patches.

virtnet_napi_disable_all() & virtnet_napi_enable_all() could be added in
a separate patch for example.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/