lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Jul 2014 10:44:46 +0800 From: Jason Wang <jasowang@...hat.com> To: Eric Dumazet <eric.dumazet@...il.com> CC: rusty@...tcorp.com.au, mst@...hat.com, virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Vlad Yasevich <vyasevic@...hat.com> Subject: Re: [PATCH net-next] virtio-net: rx busy polling support On 07/15/2014 06:21 PM, Eric Dumazet wrote: > On Tue, 2014-07-15 at 17:41 +0800, Jason Wang wrote: >> Add basic support for rx busy polling. >> >> 1 byte netperf tcp_rr on mlx4 shows 116% improvement: the transaction >> rate was increased from 9151.94 to 19787.37. > This is a misleading changelog. > > You forgot to describe how you allowed busy polling, as it is not > 'automatic' > > If not, this patch adds two spinlock/unlock pairs in fast path. Ok. > Also, it looks like you could split this in smaller patches. > > virtnet_napi_disable_all() & virtnet_napi_enable_all() could be added in > a separate patch for example. Sure, will split this patch into smaller ones in V2. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists