linux-kernel - Re: [PATCH] net: clean up some sparse endianness warnings in ipv6.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140715131716.7e14c493@tlielax.poochiereds.net>
Date:	Tue, 15 Jul 2014 13:17:16 -0400
From:	Jeff Layton <jeff.layton@...marydata.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	davem@...emloft.net, kuznet@....inr.ac.ru, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-nfs@...r.kernel.org
Subject: Re: [PATCH] net: clean up some sparse endianness warnings in ipv6.h

On Tue, 15 Jul 2014 10:01:07 -0700
Christoph Hellwig <hch@...radead.org> wrote:

> >  #if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) && BITS_PER_LONG == 64
> > -	const unsigned long *ul = (const unsigned long *)a;
> > +	const __be64 *be = (const __be64 *)a;
> >  
> > -	return (ul[0] | (ul[1] ^ cpu_to_be64(1))) == 0UL;
> > +	return (be[0] | (be[1] ^ cpu_to_be64(1))) == cpu_to_be64(0UL);
> 
> Do you need the swap for 0UL?  I know sparse treats 0 as special, so why
> wouldn't it treat 0UL special?  Or just remove the 0UL postfix, no need
> for it in a simple comparism.
> 
> Otherwise looks fine to me.

Maybe not, I did it for completeness sake. I'll see if I can remove
that. The macros do the conversion at compile time though so it
shouldn't hurt anything either way.

-- 
Jeff Layton <jlayton@...marydata.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/