linux-kernel - Re: [PATCH 1/1] fs/ubifs/super.c: replace seq_printf by seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Jul 2014 22:10:24 +0200
From:	Richard Weinberger <richard.weinberger@...il.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Artem Bityutskiy <dedekind1@...il.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>
Subject: Re: [PATCH 1/1] fs/ubifs/super.c: replace seq_printf by seq_puts

On Tue, Jul 15, 2014 at 9:26 PM, Fabian Frederick <fabf@...net.be> wrote:
> Fix checkpatch warnings:
> "WARNING: Prefer seq_puts to seq_printf"

Can you explain why seq_puts() is preferred over seq_printf()?

> Cc: Artem Bityutskiy <dedekind1@...il.com>
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: linux-mtd@...ts.infradead.org
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  fs/ubifs/super.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index 3904c85..e5bd068 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -424,19 +424,19 @@ static int ubifs_show_options(struct seq_file *s, struct dentry *root)
>         struct ubifs_info *c = root->d_sb->s_fs_info;
>
>         if (c->mount_opts.unmount_mode == 2)
> -               seq_printf(s, ",fast_unmount");
> +               seq_puts(s, ",fast_unmount");
>         else if (c->mount_opts.unmount_mode == 1)
> -               seq_printf(s, ",norm_unmount");
> +               seq_puts(s, ",norm_unmount");
>
>         if (c->mount_opts.bulk_read == 2)
> -               seq_printf(s, ",bulk_read");
> +               seq_puts(s, ",bulk_read");
>         else if (c->mount_opts.bulk_read == 1)
> -               seq_printf(s, ",no_bulk_read");
> +               seq_puts(s, ",no_bulk_read");
>
>         if (c->mount_opts.chk_data_crc == 2)
> -               seq_printf(s, ",chk_data_crc");
> +               seq_puts(s, ",chk_data_crc");
>         else if (c->mount_opts.chk_data_crc == 1)
> -               seq_printf(s, ",no_chk_data_crc");
> +               seq_puts(s, ",no_chk_data_crc");
>
>         if (c->mount_opts.override_compr) {
>                 seq_printf(s, ",compr=%s",
> --
> 1.8.4.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/