linux-kernel - Re: [PATCH net-next v9 2/9] net: nl80211 - make rdev_add_virtual_intf take name_assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1405587855.20120.0.camel@jlt4.sipsolutions.net>
Date:	Thu, 17 Jul 2014 11:04:15 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Tom Gundersen <teg@...m.no>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	linux-kernel@...r.kernel.org,
	John Linville <linville@...driver.com>
Subject: Re: [PATCH net-next v9 2/9] net: nl80211 - make
 rdev_add_virtual_intf take name_assign_type

On Thu, 2014-07-17 at 10:06 +0200, Tom Gundersen wrote:
> Pass the value down and set it at the same place the name itself is set.

Huh? What's this? Can you explain why?

>  static struct wireless_dev *ath6kl_cfg80211_add_iface(struct wiphy *wiphy,
>  						      const char *name,
> +						      unsigned char name_assign_type,

unsigned char for an enum is really odd.

johannes


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/