lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Jul 2014 11:23:06 +0200 From: Johannes Berg <johannes@...solutions.net> To: Tom Gundersen <teg@...m.no> Cc: netdev <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>, LKML <linux-kernel@...r.kernel.org>, John Linville <linville@...driver.com> Subject: Re: [PATCH net-next v9 2/9] net: nl80211 - make rdev_add_virtual_intf take name_assign_type On Thu, 2014-07-17 at 11:16 +0200, Tom Gundersen wrote: > >> static struct wireless_dev *ath6kl_cfg80211_add_iface(struct wiphy *wiphy, > >> const char *name, > >> + unsigned char name_assign_type, > > > > unsigned char for an enum is really odd. > > Hm, this was based on the addr_assign_type attribute, which also is an > unsigned char (and serves a very similar purpose). > > Out of interest, what would you have preferred (and why)? Even if it eventually ends up being assigned to a u8 or something, it seems passing it around as an enum makes the interfaces better? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists