lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Jul 2014 11:04:51 -0400 From: Murali Karicheri <m-karicheri2@...com> To: Pratyush Anand <pratyush.anand@...com> CC: "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Santosh Shilimkar <santosh.shilimkar@...com>, Russell King <linux@....linux.org.uk>, Grant Likely <grant.likely@...aro.org>, Rob Herring <robh+dt@...nel.org>, Mohit KUMAR DCG <Mohit.KUMAR@...com>, Jingoo Han <jg1.han@...sung.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Richard Zhu <r65037@...escale.com>, Kishon Vijay Abraham I <kishon@...com>, Marek Vasut <marex@...x.de>, Arnd Bergmann <arnd@...db.de>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Randy Dunlap <rdunlap@...radead.org> Subject: Re: [PATCH v5 3/5] PCI: designware: enhance dw_pcie_host_init() to support v3.65 DW hardware On 07/16/2014 11:36 PM, Pratyush Anand wrote: > On Thu, Jul 17, 2014 at 12:38:04AM +0800, Murali Karicheri wrote: >> keystone PCI controller is based on v3.65 designware hardware. This >> version differs from newer versions of the hardware in few functional >> areas discussed below that makes it necessary to change dw_pcie_host_init() >> to support v3.65 based PCI controller. >> >> 1. No support for ATU port. So any ATU specific resource handling code >> is to be bypassed for v3.65 h/w. >> 2. MSI controller uses Application space to implement MSI and 32 MSI >> interrupts are multiplexed over 8 IRQs to the host. Hence the code >> to process MSI IRQ needs to be different. This patch allows platform >> driver to provide its own irq_domain_ops ptr to irq_domain_add_linear() >> through an API callback from the designware core driver. >> 3. MSI interrupt generation requires EP to write to the RC's application >> register. So enhance the driver to allow setup of inbound access to >> MSI irq register as a post scan bus API callback. >> >> Signed-off-by: Murali Karicheri<m-karicheri2@...com> > Looks almost ok to me. > > Reviewed-by: Pratyush Anand<pratyush.anand@...com> > >> int __init dw_pcie_host_init(struct pcie_port *pp) >> { >> struct device_node *np = pp->dev->of_node; >> - struct of_pci_range range; >> struct of_pci_range_parser parser; >> + struct of_pci_range range; > You may avoid moving the above line. Thought the variables are to be sorted. I can fix this when I resend it today with your reviewed by and Mohit's Ack. Regards, Murali > ~Pratyush -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists