linux-kernel - Re: [PATCH] checkpatch.pl: Remove --file option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140717153838.GC22791@pd.tnic>
Date:	Thu, 17 Jul 2014 17:38:38 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Richard Weinberger <richard@....at>
Cc:	akpm@...ux-foundation.org, apw@...onical.com, joe@...ches.com,
	tytso@....edu, dwalter@...gle.com, neilb@...e.de,
	hch@...radead.org, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] checkpatch.pl: Remove --file option

On Thu, Jul 17, 2014 at 05:34:28PM +0200, Richard Weinberger wrote:
> checkpatch.pl is a nice tool to find issues in patches.
> Sadly this tool gets more and more  abused by various people to create
> style cleanups for source files within the kernel.
> In order to deal with that bad habit let's remove the --file option
> and bring checkpatch.pl back to its original purpose.
> 
> Suggested-by: NeilBrown <neilb@...e.de>
> Signed-off-by: Richard Weinberger <richard@....at>

Very good idea:

Acked-by: Borislav Petkov <bp@...e.de>

You could also make it do:

	if ($file) {
		print STDERR "Go find real bugs in the kernel instead!\n";
		exit(-1);
	}

if someone supplies --file on the cmdline.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/