| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Jul 2014 08:51:23 -0700 From: Joe Perches <joe@...ches.com> To: Richard Weinberger <richard@....at> Cc: akpm@...ux-foundation.org, apw@...onical.com, tytso@....edu, dwalter@...gle.com, bp@...e.de, neilb@...e.de, hch@...radead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] checkpatch.pl: Remove --file option On Thu, 2014-07-17 at 17:34 +0200, Richard Weinberger wrote: > checkpatch.pl is a nice tool to find issues in patches. grep is a similar tool, just less automated. > Sadly this tool gets more and more abused by various people to create > style cleanups for source files within the kernel. > In order to deal with that bad habit let's remove the --file option > and bring checkpatch.pl back to its original purpose. Any tool can be misused. diff -urN /dev/null $file | ./scripts/checkpatch.pl - does the same thing as --file so I don't see any real fundamental difference. I think it should really only be used in --file mode on drivers/staging/. I wouldn't mind adding some additional "yes, I really mean to do this" cmd-line flag when it's used on any file outside of staging with some additional warning that "--file" is discouraged outside of staging when it's not there. But additional documentation only goes so far. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists