linux-kernel - Re: [PATCH] checkpatch.pl: Remove --file option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140717160236.GD22791@pd.tnic>
Date:	Thu, 17 Jul 2014 18:02:36 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Joe Perches <joe@...ches.com>
Cc:	Richard Weinberger <richard@....at>, akpm@...ux-foundation.org,
	apw@...onical.com, tytso@....edu, dwalter@...gle.com, bp@...e.de,
	neilb@...e.de, hch@...radead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch.pl: Remove --file option

On Thu, Jul 17, 2014 at 08:51:23AM -0700, Joe Perches wrote:
> grep is a similar tool, just less automated.

And still, we don't want to encourage people with useless cleanups.

> I think it should really only be used in --file mode
> on drivers/staging/.

Also dumb idea - having to look at a single patch "correcting" a whole
file in staging without any explanation why it is done is not something
we want to encourage either.

People cleaning up staging should first understand what they're doing
and not listen to some script what to do.

> I wouldn't mind adding some additional "yes, I really
> mean to do this" cmd-line flag when it's used on any
> file outside of staging with some additional warning
> that "--file" is discouraged outside of staging when
> it's not there.

No, checkpatch should only check patches and not whole file. It is
wrong. Fullstop.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/