lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Jul 2014 18:52:35 +0200 From: Bastian Hecht <hechtb@...il.com> To: Thierry Reding <thierry.reding@...il.com> Cc: linux-i2c@...r.kernel.org, Linux-SH <linux-sh@...r.kernel.org>, Tomoya MORINAGA <tomoya.rohm@...il.com>, Wolfram Sang <wsa@...-dreams.de>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Laxman Dewangan <ldewangan@...dia.com>, Stephen Warren <swarren@...dotorg.org>, "open list:TEGRA ARCHITECTUR..." <linux-tegra@...r.kernel.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 5/5] i2c: tegra: Remove suspension check 2014-07-17 16:59 GMT+02:00 Thierry Reding <thierry.reding@...il.com>: > On Thu, Jul 17, 2014 at 04:48:40PM +0200, Bastian Hecht wrote: > [...] >> #ifdef CONFIG_PM_SLEEP >> -static int tegra_i2c_suspend(struct device *dev) >> -{ >> - struct tegra_i2c_dev *i2c_dev = dev_get_drvdata(dev); >> - >> - i2c_lock_adapter(&i2c_dev->adapter); >> - i2c_dev->is_suspended = true; >> - i2c_unlock_adapter(&i2c_dev->adapter); >> - >> - return 0; >> -} >> - >> static int tegra_i2c_resume(struct device *dev) >> { >> struct tegra_i2c_dev *i2c_dev = dev_get_drvdata(dev); >> @@ -842,14 +827,12 @@ static int tegra_i2c_resume(struct device *dev) >> return ret; >> } >> >> - i2c_dev->is_suspended = false; >> - >> i2c_unlock_adapter(&i2c_dev->adapter); >> >> return 0; >> } >> >> -static SIMPLE_DEV_PM_OPS(tegra_i2c_pm, tegra_i2c_suspend, tegra_i2c_resume); >> +static SIMPLE_DEV_PM_OPS(tegra_i2c_pm, tegra_i2c_resume); > > Shouldn't this be: > > static SIMPLE_DEV_OPS(tegra_i2c_pm, NULL, tegra_i2c_resume); > > instead? Oh yes thanks. I made the same mistake in [PATCH 3/5] too. Thanks, Bastian > Thierry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists